Astral04/studiobeve.no
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix "Conflict. Timeslot is taken" raw-JSON error on booking

Browse Source 
Customers intermittently hit a full-screen raw JSON error when booking:
{"error":"Conflict. Timeslot is taken or does not fit the service."}

booking_process() re-validates the chosen slot at submit time and returned
409/403 raw JSON. Because the public booking form is a full-page POST, that
JSON filled the whole screen.

The trigger is a double submit. After inserting the booking, booking_process()
synchronously runs two Google Calendar createEvent calls, a lunch sync, an ntfy
push and an SMTP confirmation e-mail before redirecting - several seconds - and
the submit button was never disabled. On mobile the guest taps "Send" again; the
second request arrives after the first has committed, so the slot reads as taken.

Evidence: 168 duplicate booking pairs exist in prod (same guest, slot and worker,
consecutive booking ids, including runs of four). All are from 2025, none from
2026 - the 409 guard added around May 2025 converted those silent duplicates
into today's visible error.

Prevent the double submit:
- disable the submit button and relabel it on first submit, ignore later ones
- add a hidden sendBooking field, since disabling a submit button can drop its
  name/value from the POST and booking_process() bails to the homepage without it

Handle it gracefully when it still happens:
- new _booking_error() renders a localised page in the right skin instead of raw
  JSON, replacing all six JSON responses in booking_process()
- new booking-error views for barber/beauty in no/en/hu, each with a message per
  error case and a link back to booking
- new Service_model::getBookingBySlotAndGuest(); if the guest's own booking for
  that exact slot already exists the submit is a duplicate rather than a real
  conflict, so finish normally instead of erroring. Guarded on a non-empty
  e-mail, as admin block bookings are stored with an empty guest_email.

No schema change. Verified on test, dev and prod: friendly page in all three
languages and both skins, double submit redirects to booking-finished without
creating a duplicate row, and no raw JSON in any response.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TJso3iGT7TkW5tm4RSBohs
This commit is contained in:
Ubuntu
2026-07-21 16:21:53 +00:00
co-authored by Claude Opus 4.8
parent 06966a898a
commit 0fd7f7a7a5
10 changed files with 201 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/views/pages/barber-booking-error.php
Executable
+12
View File
@@ -0,0 +1,12 @@
<?php
include(getcwd().'/application/views/includes/barber-skeleton-top.php');
$langArray = array('en', 'hu', 'no');
if(in_array($selectedLang, $langArray)){
include(getcwd().'/application/views/pages/includes/booking-error-form-'.$selectedLang.'.php');
}
else{
include(getcwd().'/application/views/pages/includes/booking-error-form-en.php');
}
include(getcwd().'/application/views/includes/barber-skeleton-bottom.php');
?>
application/views/pages/beauty-booking-error.php
Executable
+12
View File
@@ -0,0 +1,12 @@
<?php
include(getcwd().'/application/views/includes/beauty-skeleton-top.php');
$langArray = array('en', 'hu', 'no');
if(in_array($selectedLang, $langArray)){
include(getcwd().'/application/views/pages/includes/booking-error-form-'.$selectedLang.'.php');
}
else{
include(getcwd().'/application/views/pages/includes/booking-error-form-en.php');
}
include(getcwd().'/application/views/includes/beauty-skeleton-bottom.php');
?>
application/views/pages/includes/booking-error-form-en.php
Executable
+25
View File
@@ -0,0 +1,25 @@
<?php
$bookingErrorMessages = array(
'slot_taken' => 'This time slot was taken while you were filling in the form. Please choose another time.',
'worker_unavailable' => 'The selected staff member is not working on this day. Please choose another day.',
'outside_schedule' => 'The selected time is outside the staff member\'s working hours. Please choose another time.',
'alternate_week' => 'The selected staff member only works every second week. Please choose another day.',
'after_hours' => 'The treatment would not finish before closing time. Please choose an earlier time.',
'too_far' => 'Bookings can only be made up to 3 months in advance.',
'default' => 'Something went wrong with your booking. Please try again.',
);
$shownError = isset($bookingErrorCode) && isset($bookingErrorMessages[$bookingErrorCode])
? $bookingErrorMessages[$bookingErrorCode]
: $bookingErrorMessages['default'];
$backSubpage = isset($subpage) && $subpage != '' ? $subpage : 'barber';
$backUrl = SITEURL.'en/booking/'.$backSubpage;
?>
<div class="bookingContainer" style="min-height:500px;">
<div class="bookingThankYouTitle">This time is no longer available</div>
<div class="bookingThankYouMessageTitle"><?php echo $shownError;?></div>
<div style="text-align:center; margin-top:30px;">
<a href="<?php echo $backUrl;?>" style="display:inline-block; padding:12px 28px; background:#000; color:#fff; text-decoration:none; border-radius:5px; font-size:16px;">Back to booking</a>
</div>
</div>
application/views/pages/includes/booking-error-form-hu.php
Executable
+25
View File
@@ -0,0 +1,25 @@
<?php
$bookingErrorMessages = array(
'slot_taken' => 'Ezt az időpontot sajnos lefoglalták, amíg az űrlapot kitöltötte. Kérjük, válasszon másik időpontot.',
'worker_unavailable' => 'A kiválasztott kolléga ezen a napon nem dolgozik. Kérjük, válasszon másik napot.',
'outside_schedule' => 'A kiválasztott időpont a kolléga munkaidején kívül esik. Kérjük, válasszon másik időpontot.',
'alternate_week' => 'A kiválasztott kolléga csak kéthetente dolgozik. Kérjük, válasszon másik napot.',
'after_hours' => 'A kezelés nem érne véget zárásig. Kérjük, válasszon korábbi időpontot.',
'too_far' => 'Foglalás legfeljebb 3 hónappal előre adható le.',
'default' => 'Hiba történt a foglalás során. Kérjük, próbálja újra.',
);
$shownError = isset($bookingErrorCode) && isset($bookingErrorMessages[$bookingErrorCode])
? $bookingErrorMessages[$bookingErrorCode]
: $bookingErrorMessages['default'];
$backSubpage = isset($subpage) && $subpage != '' ? $subpage : 'barber';
$backUrl = SITEURL.'hu/booking/'.$backSubpage;
?>
<div class="bookingContainer" style="min-height:500px;">
<div class="bookingThankYouTitle">Ez az időpont már nem foglalható</div>
<div class="bookingThankYouMessageTitle"><?php echo $shownError;?></div>
<div style="text-align:center; margin-top:30px;">
<a href="<?php echo $backUrl;?>" style="display:inline-block; padding:12px 28px; background:#000; color:#fff; text-decoration:none; border-radius:5px; font-size:16px;">Vissza a foglaláshoz</a>
</div>
</div>
application/views/pages/includes/booking-error-form-no.php
Executable
+25
View File
@@ -0,0 +1,25 @@
<?php
$bookingErrorMessages = array(
'slot_taken' => 'Dette tidspunktet ble dessverre opptatt mens du fylte ut skjemaet. Vennligst velg et annet tidspunkt.',
'worker_unavailable' => 'Den valgte medarbeideren jobber ikke denne dagen. Vennligst velg en annen dag.',
'outside_schedule' => 'Det valgte tidspunktet er utenfor medarbeiderens arbeidstid. Vennligst velg et annet tidspunkt.',
'alternate_week' => 'Den valgte medarbeideren jobber kun annenhver uke. Vennligst velg en annen dag.',
'after_hours' => 'Behandlingen rekker ikke å bli ferdig innen stengetid. Vennligst velg et tidligere tidspunkt.',
'too_far' => 'Du kan kun bestille time inntil 3 måneder frem i tid.',
'default' => 'Noe gikk galt med bestillingen. Vennligst prøv igjen.',
);
$shownError = isset($bookingErrorCode) && isset($bookingErrorMessages[$bookingErrorCode])
? $bookingErrorMessages[$bookingErrorCode]
: $bookingErrorMessages['default'];
$backSubpage = isset($subpage) && $subpage != '' ? $subpage : 'barber';
$backUrl = SITEURL.'no/booking/'.$backSubpage;
?>
<div class="bookingContainer" style="min-height:500px;">
<div class="bookingThankYouTitle">Tidspunktet er ikke lenger tilgjengelig</div>
<div class="bookingThankYouMessageTitle"><?php echo $shownError;?></div>
<div style="text-align:center; margin-top:30px;">
<a href="<?php echo $backUrl;?>" style="display:inline-block; padding:12px 28px; background:#000; color:#fff; text-decoration:none; border-radius:5px; font-size:16px;">Tilbake til bestilling</a>
</div>
</div>
application/views/pages/includes/booking-form-en.php
+14
View File
@@ -187,6 +187,7 @@
<div class="bookingButtonContainer">
<input type="button" class="leftButton bookingButton" onclick="goToStep(3);" value="Back"/>
<input type="hidden" name="subpage" value="<?php echo $subpage;?>">
<input type="hidden" name="sendBooking" value="1">
<input type="submit" id="sendBooking" class="rightButton bookingSubmit" for="bookingStepForm" name="sendBooking" value="Send"/>
</div>
@@ -200,6 +201,19 @@
<script>
$(document).ready(function(){
// Prevent double submission. The booking POST stays open for several
// seconds (Google Calendar + confirmation e-mail), so an impatient
// second tap used to hit the server as a separate booking attempt.
var bookingSubmitInProgress = false;
$('#sendBooking').closest('form').on('submit', function(e){
if(bookingSubmitInProgress){
e.preventDefault();
return false;
}
bookingSubmitInProgress = true;
$('#sendBooking').prop('disabled', true).val('Sending...');
});
$('#booking_time').change(function(){
if($('#booking_time').val() != ''){
$('#isTimeSelectedBtn').prop('disabled', false);
application/views/pages/includes/booking-form-hu.php
+14
View File
@@ -188,6 +188,7 @@
<div class="bookingButtonContainer">
<input type="button" class="leftButton bookingButton" onclick="goToStep(3);" value="Vissza"/>
<input type="hidden" name="subpage" value="<?php echo $subpage;?>">
<input type="hidden" name="sendBooking" value="1">
<input type="submit" id="sendBooking" class="rightButton bookingSubmit" for="bookingStepForm" name="sendBooking" value="Elküld"/>
</div>
</div>
@@ -199,6 +200,19 @@
<script>
$(document).ready(function(){
// Prevent double submission. The booking POST stays open for several
// seconds (Google Calendar + confirmation e-mail), so an impatient
// second tap used to hit the server as a separate booking attempt.
var bookingSubmitInProgress = false;
$('#sendBooking').closest('form').on('submit', function(e){
if(bookingSubmitInProgress){
e.preventDefault();
return false;
}
bookingSubmitInProgress = true;
$('#sendBooking').prop('disabled', true).val('Küldés...');
});
$('#booking_time').change(function(){
if($('#booking_time').val() != ''){
$('#isTimeSelectedBtn').prop('disabled', false);
application/views/pages/includes/booking-form-no.php
+14
View File
@@ -188,6 +188,7 @@ if (is_array($services) && count($services) > 0) {
<div class="bookingButtonContainer">
<input type="button" class="leftButton bookingButton" onclick="goToStep(3);" value="Tilbake"/>
<input type="hidden" name="subpage" value="<?php echo $subpage;?>">
<input type="hidden" name="sendBooking" value="1">
<input type="submit" id="sendBooking" class="rightButton bookingSubmit" for="bookingStepForm" name="sendBooking" value="Sende"/>
</div>
</div>
@@ -199,6 +200,19 @@ if (is_array($services) && count($services) > 0) {
<script>
$(document).ready(function(){
// Prevent double submission. The booking POST stays open for several
// seconds (Google Calendar + confirmation e-mail), so an impatient
// second tap used to hit the server as a separate booking attempt.
var bookingSubmitInProgress = false;
$('#sendBooking').closest('form').on('submit', function(e){
if(bookingSubmitInProgress){
e.preventDefault();
return false;
}
bookingSubmitInProgress = true;
$('#sendBooking').prop('disabled', true).val('Sender...');
});
$('#booking_time').change(function(){
if($('#booking_time').val() != ''){
$('#isTimeSelectedBtn').prop('disabled', false);