An address like "asdf" used to be accepted: the field was type="text" with
only `required`, and there was no server-side check. createBooking() runs
long before sendEmail(), so the failure was silent rather than loud -
reproduced end to end on test:
- the booking row WAS created, with a manage_token
- PHPMailer's addAddress() threw, so nothing was ever sent
- the Location header was already queued, so the guest was redirected to
the normal "booking finished" page and saw success
- Evelin is a CC on that same message, so the salon was not told either
- the guest had no manage link, so they could not cancel
Fixes
- booking_process() rejects an empty or malformed address BEFORE any write,
returning invalid_email / HTTP 400. Message added in all three languages,
worded to say why it matters (the confirmation and the manage link go
there). filter_var is equal-or-stricter than PHPMailer's own validator -
checked against it on ten cases - so anything accepted here cannot throw
later.
- The three public booking forms use type="email", so most typos never
reach the server.
- Removed three debug echoes from User_model::sendEmail() that leaked $lang
and Hungarian strings ("Üzenet elküldve", "Üzenetküldési hiba. Mailer
Error: ...") into the guest-facing response.
Scope
- Public flow only. 508 existing bookings have an empty guest_email because
admin-created block bookings legitimately have none; those go through
Admin::booking_process(), which is untouched, and its form stays
type="text".
- Not covered: a valid address whose SMTP delivery fails still leaves the
booking created and the guest seeing success, logged only via
log_message(). Different failure mode, needs a separate decision.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
224 lines
9.0 KiB
PHP
Executable File
224 lines
9.0 KiB
PHP
Executable File
<?php
|
|
|
|
require getcwd().'/vendor/autoload.php';
|
|
use PHPMailer\PHPMailer\PHPMailer;
|
|
use PHPMailer\PHPMailer\SMTP;
|
|
use PHPMailer\PHPMailer\Exception;
|
|
|
|
|
|
class User_model extends CI_Model {
|
|
|
|
function __construct(){
|
|
parent::__construct();
|
|
}
|
|
|
|
public function userCanLogin($username, $password){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users WHERE username = ? AND password = ? AND is_enabled = 1 LIMIT 1', array($username, hash('sha256', $password)));
|
|
|
|
if($query->num_rows() == 1){
|
|
return 1;
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
public function getAllUser(){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users JOIN permissions ON users.permission_slug = permissions.permission_slug ORDER BY fullname ASC');
|
|
$userResults = $query->result();
|
|
|
|
foreach($userResults as $userResultItem){
|
|
if($userResultItem->profile_img_url == ''){
|
|
$userResultItem->profile_img_url = base_url().'img/default_profile.jpg';
|
|
}
|
|
}
|
|
return $userResults;
|
|
}
|
|
|
|
public function getUserByUsername($username){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users JOIN permissions ON users.permission_slug = permissions.permission_slug WHERE username = ? LIMIT 1', array($username));
|
|
if($query->num_rows() == 1){
|
|
|
|
if($query->result()[0]->profile_img_url == ''){
|
|
$query->result()[0]->profile_img_url = base_url().'img/default_profile.jpg';
|
|
}
|
|
return $query->result()[0];
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
public function getAllUserPermission(){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM permissions;');
|
|
if($query->num_rows() > 0){
|
|
return $query->result();
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
public function getUserById($userId){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users JOIN permissions ON users.permission_slug = permissions.permission_slug WHERE user_id = ? LIMIT 1', array($userId));
|
|
if($query->num_rows() == 1){
|
|
if($query->result()[0]->profile_img_url == ''){
|
|
$query->result()[0]->profile_img_url = base_url().'img/default_profile.jpg';
|
|
}
|
|
return $query->result()[0];
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
public function deleteUser($userId){
|
|
$this->load->database();
|
|
$query = $this->db->query('DELETE FROM users WHERE user_id = ?', array($userId));
|
|
}
|
|
|
|
public function isUsernameAvailable($username){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users WHERE username = ?', array($username));
|
|
if($query->num_rows() == 1){
|
|
return 0;
|
|
}
|
|
else{
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
public function updateUser($userId, $userArray){
|
|
$this->load->database();
|
|
$this->db->where('user_id', $userId);
|
|
$this->db->update('users', $userArray);
|
|
}
|
|
|
|
public function addNewUser($userArray){
|
|
$this->load->database();
|
|
|
|
if(!is_object($this->getUserByUsername($userArray['username']))){
|
|
$query = $this->db->query('INSERT INTO users (username, password, fullname, permission_slug, is_enabled, user_notes) VALUES(?, ?, ?, ?, ?, ?)', array($userArray['username'], hash('sha256', $userArray['password']), $userArray['fullname'], $userArray['permission_slug'], $userArray['is_enabled'], $userArray['user_notes']));
|
|
return 1;
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
|
|
}
|
|
|
|
public function getAllUserGroup(){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM permissions ORDER BY permission_name ASC;');
|
|
return $query->result();
|
|
}
|
|
|
|
public function getPermissionById($groupId){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM permissions WHERE permission_id = ? LIMIT 1', array($groupId));
|
|
return $query->result()[0];
|
|
}
|
|
|
|
public function getPermissionBySlug($permission_slug){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM permissions WHERE permission_slug = ? LIMIT 1', array($permission_slug));
|
|
return $query->result()[0];
|
|
}
|
|
|
|
public function sendEmail($addressList, $lang, $subpage){
|
|
// Import PHPMailer classes into the global namespace
|
|
// These must be at the top of your script, not inside a function
|
|
if(!empty($addressList)){
|
|
foreach($addressList as $addressListItem){
|
|
// Instantiation and passing `true` enables exceptions
|
|
$mail = new PHPMailer(true);
|
|
$mail->SMTPDebug = false;
|
|
$mail->do_debug = 1;
|
|
try {
|
|
//Server settings
|
|
$mail->CharSet = 'UTF-8';
|
|
//$mail->SMTPDebug = SMTP::DEBUG_SERVER; // Enable verbose debug output
|
|
$mail->isSMTP(); //Send using SMTP
|
|
$mail->Host = 'mail.absolutesolution.hu'; //Set the SMTP server to send through
|
|
$mail->SMTPAuth = true; //Enable SMTP authentication
|
|
$mail->Username = 'reservations@studiobeve.no'; //SMTP username
|
|
$mail->Password = 'StudioBeve-1234'; //SMTP password
|
|
$mail->SMTPSecure = PHPMailer::ENCRYPTION_SMTPS; //Enable TLS encryption; `PHPMailer::ENCRYPTION_SMTPS` encouraged
|
|
$mail->Port = 465; //TCP port to connect to, use 465 for `PHPMailer::ENCRYPTION_SMTPS` above
|
|
|
|
//Recipients
|
|
$mail->setFrom('reservations@studiobeve.no', '[studiobeve]');
|
|
$mail->addAddress($addressListItem['addressee_email'], $addressListItem['addressee_name']); // Add a recipient
|
|
//$mail->addAddress('ellen@example.com'); // Name is optional
|
|
//$mail->addReplyTo('info@example.com', 'Information');
|
|
$mail->addCC('evelin@studiobeve.no');
|
|
//$mail->addBCC('bcc@example.com');
|
|
|
|
// Attachments
|
|
if(is_array($addressListItem['attachments'])){
|
|
$attachments = $addressListItem['attachments'];
|
|
foreach($attachments as $attachmentsItem){
|
|
$mail->addAttachment(getcwd().'/documents/'.$attachmentsItem); // Add attachments
|
|
}
|
|
}
|
|
//$mail->addAttachment('/tmp/image.jpg', 'new.jpg'); // Optional name
|
|
|
|
// Content
|
|
$mail->isHTML(true); // Set email format to HTML
|
|
$mail->Subject = $addressListItem['subject'];
|
|
ob_start();
|
|
$body = ob_get_clean();
|
|
$body .= $addressListItem['content'];
|
|
|
|
$mail->Body = $body;
|
|
//$mail->AltBody = strip_tags($answer_message);
|
|
|
|
$mail->send();
|
|
if($subpage != ''){
|
|
header('location:'.base_url().$lang.'/booking-finished/'.$subpage);
|
|
}
|
|
|
|
} catch (Exception $e) {
|
|
//header('location:'.base_url().'manage-applicants/?email-sent=false&error='.$mail->ErrorInfo);
|
|
log_message('error', 'sendEmail FAILED: ' . $mail->ErrorInfo);
|
|
// Do NOT echo the mailer error. This runs after the booking is
|
|
// saved and after the redirect header is queued, so it only leaks
|
|
// Hungarian internals into a response the guest never reads.
|
|
// The log_message() above is the record.
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
public function is_user_admin($username){
|
|
$this->load->database();
|
|
$query = $this->db->query('SELECT * FROM users JOIN permissions ON users.permission_slug = permissions.permission_slug WHERE username = ? LIMIT 1', array($username));
|
|
if($query->num_rows() == 1){
|
|
if($query->result()[0]->permission_slug == 'admin'){
|
|
return 1;
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
else{
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
?>
|